Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openraPackages.engines.bleed: fix hash #61749

Merged
merged 1 commit into from May 20, 2019
Merged

openraPackages.engines.bleed: fix hash #61749

merged 1 commit into from May 20, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

#61394 (comment)

cc @msteen

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from c0bw3b May 20, 2019 11:51
@aanderse aanderse mentioned this pull request May 20, 2019
Merged
10 tasks
c0bw3b
c0bw3b approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me

@msteen
Copy link
Contributor

msteen commented May 20, 2019

Yep, my bad! I initially used the commit that Arch Linux's package for the bleeding release of OpenRA uses and afterwards updated it to the commit just before OpenRA changed the building process. I seemed to only have tested the build and not updated the hash accordingly. Thank you for the fix, that is indeed the hash it should have had!

@c0bw3b c0bw3b merged commit 5711eb5 into NixOS:master May 20, 2019
@aanderse aanderse deleted the openra branch May 20, 2019 15:39
@aanderse
Copy link
Member Author

Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @msteen @c0bw3b