jackaudio: restrict aften dependency to Darwin #61670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build jack2 |
|
Can we only depend on it for darwin? |
|
This should fix #61571 |
thefloweringash
force-pushed
the
jackaudio-aften
branch
from
32d461d
to
bee067b
Compare
|
The change in #60447 seemed to intentionally move aften from Darwin to common, but the jack configuration script only checks for it on Darwin. if conf.env['IS_MACOSX']:
conf.check(lib='aften', uselib='AFTEN', define_name='AFTEN')PR updated to move it back. |
Right I looked at the same part of the configuration script. |
|
@thefloweringash Can you change the commit msg to be succinct to what's happening now? Other than that, once this builds I will merge it. @GrahamcOfBorg build jack2 |
thefloweringash
force-pushed
the
jackaudio-aften
branch
from
bee067b
to
257f930
Compare
thefloweringash
changed the title
ofborg
bot
added
6.topic: darwin
|
@GrahamcOfBorg build jack2 |
|
Merged to staging in 19dd115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The jackaudio package was changed in #60447, which brought in the aften dependency on linux, but aften doesn't build on aarch64.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)