Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: Add enableStatic flag #61611

Merged
merged 3 commits into from May 28, 2019
Merged

openblas: Add enableStatic flag #61611

merged 3 commits into from May 28, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented May 17, 2019 •
edited

Motivation for this change

Building static Haskell executables involving hmatrix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested review from matthewbauer and dtzWill May 17, 2019 02:48
@nh2
Copy link
Contributor Author

nh2 commented May 17, 2019

Don't merge yet:

This isn't working because our version doesn't have OpenMathLib/OpenBLAS#2038

@matthewbauer
Copy link
Member

Looks okay! Could you also add the override to pkg/top-level/static.nix?

@nh2 nh2 mentioned this pull request May 17, 2019
Closed
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented May 17, 2019

This isn't working because our version doesn't have xianyi/OpenBLAS#2038

Will be fixed with #61614

@nh2
Copy link
Contributor Author

nh2 commented May 17, 2019

Looks okay! Could you also add the override to pkg/top-level/static.nix?

Added; still compiling though on my machine.

@nh2
Copy link
Contributor Author

nh2 commented May 17, 2019

@GrahamcOfBorg build pkgsStatic.openblas

@nh2
Copy link
Contributor Author

nh2 commented May 17, 2019

@matthewbauer pkgsStatic.openblas errors out with

build flags: SHELL=/nix/store/5p8qcz6i13ymgf80kimhx2g9pb5r5nia-bash-4.4-p23/bin/bash BINARY=64 CC=x86_64-unknown-linux-musl-cc CROSS=1 DYNAMIC_ARCH=1 FC=x86_64-unknown-linux-musl-gfortran HOSTCC=cc INTERFACE64=1 NO_AVX512=1 NO_BINARY_MODE=1 NO_STATIC=1 NUM_THREADS=64 PREFIX=/nix/store/y5nm9bbxmy5vjyhiz9p1kak3gvgirc6m-openblas-0.3.5-x86_64-unknown-linux-musl TARGET=ATHLON USE_OPENMP=1
/nix/store/6k95q6vvnmspf3c0nm8q55sixsvmn9nc-binutils-2.31.1/bin/ld: cannot find -lc
collect2: error: ld returned 1 exit status

even on current master.

@ofborg ofborg bot requested a review from ttuegel May 17, 2019 03:57
@FRidh FRidh merged commit 7031335 into NixOS:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dtzWill dtzWill Awaiting requested review from dtzWill

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @matthewbauer @FRidh