New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cssom] Test the camelcased attributes are implemented as attributes. #16900
[cssom] Test the camelcased attributes are implemented as attributes. #16900
Conversation
…plemented as attributes. WebKit and Blink do not implement these correctly, and thus fail the last bit of the test.
8edf88c
to
a94364e
Compare
Alternatively, do we just want to add an
and assume that all properties defined in CSS2 are supported CSS properties? (Plus, I guess, some That would get us coverage of not just this but all the things that idlharness.js asserts about attributes. I think really ideally we'd use the data in Reffy to generate those partial interface definitions as part of the IDL defined in each spec that defines CSS properties, hmm. @foolip? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but it's indeed weird that CSSOM is not IDL-tested already. @foolip @lukebjerring?
I just sent a proposal to parse the CSS specs for properties and generate syntax tests (https://lists.w3.org/Archives/Public/www-style/2019May/0013.html), which I think it could be used to know which attributes to test, if that's desirable. |
@annevk it does have idlharness.js tested, but there's a bunch of IDL definitions where there are attributes defined for each supported CSS property (and CSSOM doesn't enumerate them), and we don't currently create an attribute for every CSS property defined in any spec. |
Ah right, it's defined in prose these days? That would indeed create this issue. 😟 |
…plemented as attributes. (#16900) WebKit and Blink do not implement these correctly, and thus fail the last bit of the test.
WebKit and Blink do not implement these correctly, and thus fail the last bit of
the test.