Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo.map: fix URL #61698

Closed
wants to merge 1 commit into from
Closed

neo.map: fix URL #61698

wants to merge 1 commit into from

Conversation

Taeradan
Copy link
Contributor

Current URL is no longer available.

Motivation for this change

Change already merged into master, but needed on release-19.03 because the problem fixed prevents upgrading from older releases (at least from 18.03).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samsonan-it @Taeradan
neo.map: fix URL
a392bc1 
Current URL is no longer available.
vcunat pushed a commit that referenced this pull request May 19, 2019
@samsonan-it @vcunat
Merge #60201: neo.map: fix URL
3366e98 
Current URL is no longer available.

(cherry picked from commit 6e100ae)
Close #61698.
@vcunat
Copy link
Member

vcunat commented May 19, 2019

I pushed 3366e98 directly instead, as we require mentioning the master commit (git cherry-pick -x).

@vcunat vcunat closed this May 19, 2019
@Taeradan
Copy link
Contributor Author

@vcunat Thanks, I didn't know about the "-x" option. I don't see it in CONTRIBUTING.md, where are described the extra rules ?

@Taeradan Taeradan deleted the fix-neo.map branch May 19, 2019 08:50
@vcunat
Copy link
Member

vcunat commented May 19, 2019

It's in the docs linked from CONTRIBUTING.md: https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

@Taeradan
Copy link
Contributor Author

Ok, I'll read that, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taeradan @vcunat @samsonan-it