Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kanji-stroke-order-font: init at 4.002 #61659

Merged
merged 2 commits into from May 19, 2019
Merged

kanji-stroke-order-font: init at 4.002 #61659

merged 2 commits into from May 19, 2019

Conversation

ptrhlm
Copy link
Contributor

@ptrhlm ptrhlm commented May 18, 2019

Motivation for this change

This pull request adds font with Japanese kanji characters, annotated with stroke order.
The font is used for learning Japanese, for example with Anki flashcards.

Additionally, I added myself to maintainer list in order to maintain this package (I'm not sure if I should - if not, I'll remove that commit).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg requested changes May 18, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty cool font!
Tested it and it works :)

Yeah of course, having a maintainer is always preferred.

pkgs/data/fonts/kanji-stroke-order-font/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/kanji-stroke-order-font/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg JohnAZoidberg mentioned this pull request May 18, 2019
Merged
10 tasks
@ptrhlm ptrhlm changed the title kanji-stroke-order-font: init at v4.002 kanji-stroke-order-font: init at 4.002 May 18, 2019
@ptrhlm
Copy link
Contributor Author

ptrhlm commented May 18, 2019

@JohnAZoidberg Thank you for your suggestions! I've committed the requested changes :)

@marsam marsam merged commit 5f63849 into NixOS:master May 19, 2019
@marsam
Copy link
Contributor

marsam commented May 19, 2019

Thanks!

@ptrhlm ptrhlm deleted the kanji-stroke-order-font branch May 22, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ptrhlm @marsam @JohnAZoidberg