Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.stravalib: init at 0.10.2 #61751

Merged
merged 2 commits into from May 20, 2019
Merged

pythonPackages.stravalib: init at 0.10.2 #61751

merged 2 commits into from May 20, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Testing out strava api over the weekend lets add it to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner May 20, 2019 13:32
@costrouc
Copy link
Member Author

Nix review passes

Result of nix-review pr 61751 1

4 package were build:
  • python27Packages.stravalib
  • python27Packages.units
  • python37Packages.stravalib
  • python37Packages.units

@marsam marsam merged commit f498dd7 into NixOS:master May 20, 2019
@marsam
Copy link
Contributor

marsam commented May 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @marsam