Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: 15.0.7 -> 15.0.8 #61752

Merged
merged 1 commit into from May 21, 2019
Merged

nextcloud: 15.0.7 -> 15.0.8 #61752

merged 1 commit into from May 21, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 20, 2019

Motivation for this change

https://nextcloud.com/changelog/#15-0-8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and fpletz May 20, 2019 13:52
@flokli flokli added the 9.needs: port to stable A PR needs a backport to the stable release. label May 20, 2019
mmahut
mmahut approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures

LGTM

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

@GrahamcOfBorg test nextcloud.basic

@Lassulus Lassulus merged commit 4bc4035 into NixOS:master May 21, 2019
@Lassulus
Copy link
Member

tested inside a VM

@Lassulus
Copy link
Member

backported in cdec621...642b36a

@flokli flokli deleted the nextcloud-15.0.8 branch May 21, 2019 13:44
@flokli
Copy link
Contributor Author

flokli commented May 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @c0bw3b @Lassulus @mmahut