Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flare: init at 1.10 #61706

Merged
merged 1 commit into from May 19, 2019
Merged

flare: init at 1.10 #61706

merged 1 commit into from May 19, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes May 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flare-engine has a mod for like translations that we might have to
care for

Also see comments.

Other than that the game did appear to function 👍

pkgs/games/flare/engine.nix Outdated Show resolved Hide resolved
pkgs/games/flare/engine.nix Outdated Show resolved Hide resolved
pkgs/games/flare/game.nix Outdated Show resolved Hide resolved
pkgs/games/flare/game.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member Author

@worldofpeace thank you for your helpful comments! Looks like I simply missed the tags on github 😊
I didn't see any mention of running those scripts in the readme/install notes that you mentioned, nor have I worked with those sorts of translations before. I suppose I could just pass python or 'gettext' in the nativeBuildInputs and then run the script in the preInstall phase maybe?

@worldofpeace
Copy link
Contributor

I didn't see any mention of running those scripts in the readme/install notes that you mentioned, nor have I worked with those sorts of translations before.

Hmm, now I'm thinking that perhaps they just use them to regenerate them and commit it to the repo.
Probably don't need to do anything for those.

worldofpeace
worldofpeace approved these changes May 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@worldofpeace worldofpeace merged commit 68d0d55 into NixOS:master May 19, 2019
@aanderse aanderse deleted the flare branch May 19, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @worldofpeace