Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRI-O package #61707

Merged
merged 1 commit into from May 20, 2019
Merged

Add CRI-O package #61707

merged 1 commit into from May 20, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 19, 2019 •
edited

This commits adds the CRI-O package, which includes the crio binary as
well as conmon and pause. The configuration is not part of this
package because it would be included in a service.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS (won't build on it)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date (not sure if I missed something here)
  • Fits CONTRIBUTING.md.

@saschagrunert
cri-o: init at version v1.14.1
b0917a5 
This commits adds the CRI-O package, which includes the `crio` binary as
well as `conmon` and `pause`. The configuration is not part of this
package because it would be included in a service.

Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@zimbatm zimbatm merged commit 9b43c29 into NixOS:master May 20, 2019
@zimbatm
Copy link
Member

zimbatm commented May 20, 2019

Thanks, and welcome to the nix ecosystem :)

@saschagrunert saschagrunert deleted the cri-o branch May 20, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @zimbatm @Janik-Haag