Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r18.03] leptonica: patch multiple CVEs #61608

Closed
wants to merge 1 commit into from
Closed

[r18.03] leptonica: patch multiple CVEs #61608

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 17, 2019

Motivation for this change

Cherrypick of #61217 to 18.03. The k2pdfopt patch (#61302) isn't needed because its custom leptonica doesn't mess with the patches in 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
leptonica: patch multiple CVEs
89b143b 
this should fix CVE-2018-3836, CVE-2018-7186, CVE-2018-7247 & CVE-2018-7440

a fix for CVE-2018-7441 & CVE-2018-7442 is *not* included as its patches
are very wide-ranging

also enable tests to give confidence that I'm not completely butchering
the code

(cherry picked from commit 0861ad5)
@infinisil
Copy link
Member

We don't do backports to 18.03 anymore (EOL in October 2018), and neither for 18.09, end of life was last month

@infinisil infinisil closed this May 17, 2019
@risicle
Copy link
Contributor Author

risicle commented May 17, 2019

eh - what's the harm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @infinisil