Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphene: init at 1.8.6 #61610

Merged
merged 2 commits into from May 22, 2019
Merged

graphene: init at 1.8.6 #61610

merged 2 commits into from May 22, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Pretty sure we'll need this for mutter in GNOME 3.34.

This pr adds:

  • this package
  • nixos test for installed tests

There's also a patch to add options for which directory the installed test stuff goes.
I probably should try to upstream that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 20, 2019

@GrahamcOfBorg build nixosTests.graphene

c0bw3b
c0bw3b approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on nixos with nix-review

@c0bw3b c0bw3b merged commit 42c0ce8 into NixOS:master May 22, 2019
@worldofpeace worldofpeace deleted the init/graphene branch June 1, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @c0bw3b