Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devede: fix runtime error #61609

Merged
merged 1 commit into from May 18, 2019
Merged

devede: fix runtime error #61609

merged 1 commit into from May 18, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

#61578

Needs backport to 19.03 as devede is currently broken there as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label May 17, 2019
@worldofpeace worldofpeace merged commit 619492c into NixOS:master May 18, 2019
@worldofpeace
Copy link
Contributor

backported in 51cc0ed

@aanderse aanderse deleted the devede branch May 18, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @worldofpeace