Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passff-host: 1.0.2 -> 1.2.1 #61735

Merged
merged 1 commit into from May 21, 2019
Merged

passff-host: 1.0.2 -> 1.2.1 #61735

merged 1 commit into from May 21, 2019

Conversation

evax
Copy link
Contributor

@evax evax commented May 20, 2019

Motivation for this change

Version 1.0.2 displays an error message with the current Firefox plugin if the otp plugin is enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented May 20, 2019

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

LGTM

@c0bw3b c0bw3b merged commit 2e3295d into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants