Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules: Ensure the colord user is a system user #61689

Merged
merged 1 commit into from May 18, 2019
Merged

nixos/modules: Ensure the colord user is a system user #61689

merged 1 commit into from May 18, 2019

Conversation

neilmayhew
Copy link
Member

Ideally, it should have an assigned uid and gid

Motivation for this change

The colord user ends up with a uid in the range reserved for normal users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@neilmayhew
nixos/modules: Ensure the colord user is a system user
f14cf43 
Ideally, it should have an assigned uid and gid
@worldofpeace
Copy link
Contributor

Hmm #58458 (comment)

worldofpeace
worldofpeace approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is something that I did forget.

@neilmayhew
Copy link
Member Author

I think the default value of isSystemUser should be changed to true to prevent this kind of thing from happening. If someone is configuring a normal user in their NixOS configuration, they'll almost certainly be using isNormalUser = true.

@worldofpeace
Copy link
Contributor

This comment

Hmm #58458 (comment)

was in response to

Ideally, it should have an assigned uid and gid

This has been discussed extensively in many places. (see #60732 (comment)).

@worldofpeace worldofpeace merged commit 1b457e7 into NixOS:master May 18, 2019
@neilmayhew neilmayhew deleted the nixos/modules/colord branch May 19, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neilmayhew @worldofpeace