[UserTimingL3] Throw error when global object is not Window object #16901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 17, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613653
branch
6 times, most recently
from
6111f6c
to
ded783e
Compare
The spec[1] says "If the global object is not a Window object, throw a TypeError". We should check whether the global object is a window object when converting a performance-timing name to timestamp. If it is not, throw a Type Error. [1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp Bug: 953869 Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662216}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613653
branch
from
ded783e
to
4f92c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec[1] says "If the global object is not a Window object, throw
a TypeError". We should check whether the global object is a window
object when converting a performance-timing name to timestamp. If
it is not, throw a Type Error.
[1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp
Bug: 953869
Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662216}