scale intrinsic size #16897
Closed
scale intrinsic size #16897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem of intrinsicsize not working properly with high density device. As well, intrinsicsize not working properly with zoom in and zoom out. In addition, as debugging I realized the test was initially written wrong, so I fixed the test. I verified the test bahavior by testing it on an image without intrinsicsize attr. In this case the image's intrinsic width / height will be used as its intrinsic dimension. Now the intrinsic dimension overridden by intrinsicsize attribute matches the behavior. Bug: 957192 Change-Id: I164809544bfad9a2d36af96b536cec735295087a
wpt-pr-bot
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem of intrinsicsize not working properly with
high density device. As well, intrinsicsize not working properly
with zoom in and zoom out.
In addition, as debugging I realized the test was initially written
wrong, so I fixed the test.
I verified the test bahavior by testing it on an image without
intrinsicsize attr. In this case the image's intrinsic width / height
will be used as its intrinsic dimension. Now the intrinsic dimension
overridden by intrinsicsize attribute matches the behavior.
Bug: 957192
Change-Id: I164809544bfad9a2d36af96b536cec735295087a
Reviewed-on: https://chromium-review.googlesource.com/1613930
WPT-Export-Revision: 3633546683753388295ef30d4855e49ea8a1f228