pythonPackages.pylint: 2.2.3 -> 2.3.1 #61648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
@GrahamcOfBorg build pythonPackages.pylint python3Packages.pylint |
marsam
reviewed
May 18, 2019
jonringer
force-pushed
the
joringer/bump_pylint
branch
from
4aff2a6
to
519196e
Compare
|
@GrahamcOfBorg build pythonPackages.pylint python3Packages.pylint python36Packages.pylint python35Packages.pylint |
|
Tested locally on NixOS and darwin |
|
The astroid update broke asttokens (on python 3). |
|
looks like upstream fixed it gristlabs/asttokens@21caaaa. I'm going to update it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pylint was broken for python3.5 an python3.6 as mentioned in #61646
looks like bumping the version fixed some of their unit tests that were failing with 3.5-3.6 interpreters.
nix-build -A python36Packages.pylintnix-build -A python35Packages.pylintnix-build -A python37Packages.pylintnix-build -A pythonPackages.pylintnow all work.
I only tested the pytest executable wrapper of build outputs, and it seems to work as expected.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Closure for python37Packages.pylint: 102.4M -> 103.3M (the others were broken)