Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchelfUnstable: 0.10-pre-20180509 -> 0.10-pre-20190328 #60944

Merged
merged 1 commit into from May 18, 2019
Merged

patchelfUnstable: 0.10-pre-20180509 -> 0.10-pre-20190328 #60944

merged 1 commit into from May 18, 2019

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented May 4, 2019 •
edited

Motivation for this change

Currently patchelfUnstable does not include the PR NixOS/patchelf#66, which is needed for some Go packages (like ngrok2).

I ran this version of patchelf on a new version of ngrok2 and now it is working whereas with version 20180509, patchelf would show the following error:

cannot find section ''
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobvanderlinden
Copy link
Member Author

I was able to build sky (which uses patchelfUnstable) on this PR. That said, running sky was broken for me, just like it was on origin/master.

I tried building virtualbox, but that took quite a long time on my laptop and cancelled it eventually.

@ofborg ofborg bot requested a review from edolstra May 4, 2019 22:15
@bobvanderlinden bobvanderlinden mentioned this pull request May 4, 2019
Merged
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 18, 2019

Ran a partial local test :

3 package were build:
patchelfUnstable virtualbox virtualboxWithExtpack

@GrahamcOfBorg build patchelfUnstable

@c0bw3b c0bw3b merged commit 8aef83d into NixOS:master May 18, 2019
@infinisil
Copy link
Member

infinisil commented May 28, 2019 •
edited

Well originally #57618 was for the Go thing, which lead to a new stable version being released for which there is #58715 now, which this PR introduced a conflict for

Some help there would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @c0bw3b @infinisil