Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gbdk-n: init at unstable-2019-03-14 #61709

Closed
wants to merge 1 commit into from
Closed

gbdk-n: init at unstable-2019-03-14 #61709

wants to merge 1 commit into from

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented May 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix build. When I run nix-review pr 61709 I get this build failure

builder for '/nix/store/sq8zy8wwvk6yh95mkrf5v4iyz5bl8p0p-gbdk-n-unstable-2019-03-14.drv' failed with exit code 2; last 10 log lines:
  bin/gbdk-n-assemble.sh ./obj/sgb.rel ./libc/sgb.s
  + sdasgb -plosgff -Ilibc ./obj/sgb.rel ./libc/sgb.s
  bin/gbdk-n-assemble.sh ./obj/crt0.rel ./libc/crt0.s
  + sdasgb -plosgff -Ilibc ./obj/crt0.rel ./libc/crt0.s
  mkdir -p ./lib
  cp ./obj/crt0.rel ./lib/
  ls ./obj/*.rel > ./obj/rels.txt
  sdcclib -l ./lib/gb.lib ./obj/rels.txt	
  /nix/store/j78ycszn9vgn0khl0lcpbd087x2mmr66-bash-4.4-p23/bin/bash: sdcclib: command not found
  make: *** [Makefile:13: lib/gb.lib] Error 127

@stale
Copy link

stale bot commented Jul 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2020
@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the gbdk-n branch October 13, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bignaux @ryantm