Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgloader: re-init at 3.6.1 #61702

Merged
merged 1 commit into from May 19, 2019
Merged

pgloader: re-init at 3.6.1 #61702

merged 1 commit into from May 19, 2019

Conversation

mguentner
Copy link
Contributor

Motivation for this change

#49478

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

7c6f434c
7c6f434c reviewed May 19, 2019
View reviewed changes
pkgs/development/tools/pgloader/default.nix Outdated
sha256 = "1sm8xmq30d1biin5br0y3vrv4fydbrzfqglz1hnvrkdyxrg7d6f9";
};

buildInputs = [ sbcl cacert sqlite freetds libzip curl git openssl makeWrapper ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't git and makeWrapper native build inputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Force pushed.

@mguentner
Copy link
Contributor Author

For the record: I tried to build it using a derivation that fetches the sources with outputHashMode = "recursive";.
This however fails because the output of the fetcher is not reproducible.

You can find my failed attempt here:
mguentner@c2f6a7d

@7c6f434c 7c6f434c merged commit e2e0439 into NixOS:master May 19, 2019
@mguentner mguentner mentioned this pull request May 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mguentner @7c6f434c