New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x264: 20170731-2245 -> 20190517-2245; add myself as maintainer #61683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this go into staging? |
c0bw3b
reviewed
May 19, 2019
It's ok for master @GrahamcOfBorg build handbrake |
ofBorg built and tested ffmpeg + handbrake ☑️ Tested some more reverse-deps on my end: 3 package were build:
So LGTM apart from nasm location |
- yasm has been replaced by nasm - both 10-bit and 8-bit are in the same binary now - patchPhase replaced with postPatch to allow patching with overrides - enableParallelBuilding enabled, long build and doesn't seem to cause issues - dev output added
c0bw3b
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yasm has been replaced by nasm
both 10-bit and 8-bit are in the same binary now
patchPhase replaced with postPatch to allow patching with overrides
enableParallelBuilding enabled, long build and doesn't seem to cause
issues
dev output added
Motivation for this change
Was using this, noticed it hadn't been updated in a long time.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)