Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm: fix "Map.! when compiling with --debug" #61680

Closed
wants to merge 1 commit into from
Closed

Elm: fix "Map.! when compiling with --debug" #61680

wants to merge 1 commit into from

Conversation

miniBill
Copy link
Contributor

@miniBill miniBill commented May 18, 2019 •
edited

Motivation for this change

The elm compiler has a long standing bug that may prevent compiling in debugging mode. The extremely slow pace of release means that this bug is open since months and will be open for many more. While it seems like there will be a 0.19.1, we have no idea on the timeframe, so we apply a proposed patch in the meantime.
This patch is a fix for #1851.

Things done
  • Regenerated versions.dat using update.sh
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member

erictapen commented May 18, 2019 •
edited

Thanks for the PR. I have no push access to Nixpkgs but I'd like to provide a first review to help committers.

Could you provide some more information about the bug you want to fix, e.g. an upstream ticket? Could you also list under "Things done", how you regenerated that versions.dat file? Is the change of versions.dat a requirement for fixing the bug or could it be left out to be applied later with a version bump of elm?

I noticed that neither of the two proposed patches are merged upstream yet. Personally I'd have a better feeling if they would be. Any chance that happens soon?

Also:
@GrahamcOfBorg build elmPackages.elm

@miniBill
Copy link
Contributor Author

miniBill commented May 19, 2019 •
edited

Thanks for the PR. I have no push access to Nixpkgs but I'd like to provide a first review to help committers.

Thank you very much =)

Could you provide some more information about the bug you want to fix, e.g. an upstream ticket? Could you also list under "Things done", how you regenerated that versions.dat file? Is the change of versions.dat a requirement for fixing the bug or could it be left out to be applied later with a version bump of elm?

Added the info to "Things done". I've used the provided script from this repo, to be completely honest I'm not sure whether updating it is required and what may happen if we don't update it (I fear heisenbugs).

I noticed that neither of the two proposed patches are merged upstream yet. Personally I'd have a better feeling if they would be. Any chance that happens soon?

I'd say that the patches will probably never be merged upstream, as the code was reworked in a different way, but there is a fork that has actually included this.
This is one of the most annoying bugs, as it's impossible to work around.

Also:
@GrahamcOfBorg build elmPackages.elm

@miniBill
Elm: fix "Map.! when compiling with --debug"
39e70f5 
The elm compiler has a long standing bug that may prevent compiling in debugging mode.
The extremely slow pace of release means that this bug is open since months and will be open for many more.
While it seems like there will be a 0.19.1 release, we have no idea on the timeframe, so we apply a proposed patch in the meantime.
This patch is a fix for #1851.
@miniBill
Copy link
Contributor Author

@GrahamcOfBorg build elmPackages.elm

@domenkozar
Copy link
Member

Closing as we're waiting on Elm 0.19.1 alpha elm/compiler#1850 (comment)

@domenkozar domenkozar closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniBill @erictapen @domenkozar