Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package some DNS security tools #61714

Merged
merged 7 commits into from May 21, 2019
Merged

Package some DNS security tools #61714

merged 7 commits into from May 21, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 19, 2019 •
edited

Motivation for this change

Refresh of #30542
And I'd like to have these tools available from nixpkgs

cc @globin @treemo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b mentioned this pull request May 19, 2019
Closed
8 tasks
@ofborg ofborg bot requested a review from globin May 19, 2019 17:10
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 19, 2019

@GrahamcOfBorg build perl528Packages.NetNetmask perl528Packages.NetWhoisIP perl528Packages.StringRandom dnsenum dnsrecon fierce theharvester

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 19, 2019

@GrahamcOfBorg build perl528Packages.NetNetmask perl528Packages.NetWhoisIP perl528Packages.StringRandom dnsenum dnsrecon fierce theharvester

@globin
Copy link
Member

globin commented May 20, 2019

@c0bw3b btw github allows multiple authors on commits: https://help.github.com/en/articles/creating-a-commit-with-multiple-authors

teto
teto reviewed May 20, 2019
View reviewed changes
pkgs/tools/security/dnsenum/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/dnsenum/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Show resolved Hide resolved
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 20, 2019

@c0bw3b btw github allows multiple authors on commits: https://help.github.com/en/articles/creating-a-commit-with-multiple-authors

Thanks, I did not know about this feature.
I'll rewrite those commits later today.

c0bw3b and others added 7 commits May 20, 2019 20:44
@c0bw3b @globin
perlPackages.StringRandom: init at 0.30
e53479a 
Co-authored-by: Robin Gloster <mail@glob.in>
@globin @c0bw3b
perlPackages.NetWhoisIP: init at 1.19
0e32aed
@c0bw3b @globin
perlPackages.NetNetmask: init at 1.9104
870b6e0 
Co-authored-by: Robin Gloster <mail@glob.in>
@c0bw3b @globin
dnsenum: init at 1.2.4.2
c29a529 
Co-authored-by: Robin Gloster <mail@glob.in>
@c0bw3b @globin
dnsrecon: init at 0.9.1
092791c 
Co-authored-by: Robin Gloster <mail@glob.in>
@c0bw3b @globin
fierce: init at 1.3.0
78d09f1 
Co-authored-by: Robin Gloster <mail@glob.in>
@c0bw3b
theharvester: 2.7.1 -> 3.0.6
17815ba
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 20, 2019

Result of nix-review pr 61714 1

7 package were build:
  • dnsenum
  • dnsrecon
  • fierce
  • perl528Packages.NetNetmask
  • perl528Packages.NetWhoisIP
  • perl528Packages.StringRandom
  • theharvester

I've been using all 4 tools successfully too

@teto
Copy link
Member

teto commented May 21, 2019

@c0bw3b ready for merge then ?

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 21, 2019

Yes it is. :) Thanks @teto

@teto teto merged commit cef246e into NixOS:master May 21, 2019
@teto
Copy link
Member

teto commented May 21, 2019

trusting you on this :p

@c0bw3b c0bw3b deleted the pkg/sec-dns-tools branch May 21, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @globin @teto