Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages: fixing generation of mathcomp extra packages #61747

Merged
merged 1 commit into from May 21, 2019
Merged

coqPackages: fixing generation of mathcomp extra packages #61747

merged 1 commit into from May 21, 2019

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

Fixing a bug in mathcomp extra packages, that prevented to generate the set coqPackages_8_10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@vbgl

@vbgl
Copy link
Contributor

vbgl commented May 20, 2019

@GrahamcOfBorg build coqPackages_8_10

@vbgl
Copy link
Contributor

vbgl commented May 20, 2019

Evaluation is still broken:

nix-build -A coqPackages_8_5 --show-trace
error: while evaluating the attribute 'coqPackages_8_5' at …/nixpkgs/pkgs/top-level/coq-packages.nix:114:3:
while evaluating 'mkCoqPackages' at …/nixpkgs/pkgs/top-level/coq-packages.nix:88:19, called from …/nixpkgs/pkgs/top-level/coq-packages.nix:114:21:
while evaluating 'filterCoqPackages' at …/nixpkgs/pkgs/top-level/coq-packages.nix:65:28, called from …/nixpkgs/pkgs/top-level/coq-packages.nix:91:10:
while evaluating anonymous function at …/nixpkgs/pkgs/top-level/coq-packages.nix:67:22, called from …/nixpkgs/pkgs/top-level/coq-packages.nix:67:7:
while evaluating 'optional' at …/nixpkgs/lib/lists.nix:241:20, called from …/nixpkgs/pkgs/top-level/coq-packages.nix:70:9:
while evaluating the attribute 'mathcomp-analysis' at …/nixpkgs/pkgs/top-level/coq-packages.nix:46:78:
attribute 'mathcomp-analysis' missing, at …/nixpkgs/pkgs/top-level/coq-packages.nix:6:45

@ofborg ofborg bot requested review from vbgl, thoughtpolice and roconnor May 20, 2019 14:55
@CohenCyril CohenCyril changed the title fixing coqPackages_8_10 coqPackages: fixing generation of mathcomp extra packages May 20, 2019
@vbgl vbgl merged commit d16a78b into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@roconnor roconnor Awaiting requested review from roconnor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenCyril @vbgl