Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refind: allows building for aarch64 #61726

Merged
merged 1 commit into from Jun 5, 2019
Merged

refind: allows building for aarch64 #61726

merged 1 commit into from Jun 5, 2019

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented May 19, 2019 •
edited

Motivation for this change

AArch64 all the things :)

Things done

This was verified with cross-compilation and native build on AArch64. The cross-compiled result was verified to boot on hardware.

  • ☑️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ☑️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ☑️ Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • 🔲 Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ☑️ Assured whether relevant documentation is up to date
  • ☑️ Fits CONTRIBUTING.md.

@GrahamcOfBorg build refind

@samueldr
Copy link
Member Author

samueldr commented May 19, 2019 •
edited

I'm not entirely confident on the patch for Make.conf, but it seemed the less convoluted way to make their build system use the right tools. Otherwise the makefile strongly assumes cross-compilation with the specified toolchain.

The actual prefix variable was already neutered via make flags, it could be kept or removed from the patch. It doesn't really matter.

cc @matthewbauer

@ofborg ofborg bot requested a review from AndersonTorres May 19, 2019 22:09
flokli
flokli reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@samueldr samueldr merged commit f6e1664 into NixOS:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @flokli