Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 2.1.0 -> 2.3.0 #61723

Merged
merged 1 commit into from May 19, 2019
Merged

buildbot: 2.1.0 -> 2.3.0 #61723

merged 1 commit into from May 19, 2019

Conversation

lopsided98
Copy link
Contributor

Update buildbot to the latest version. Also, fix the build since the tests were failing with 2.1.0, probably due to some dependency update.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 requested a review from FRidh as a code owner May 19, 2019 21:30
@veprbl
Copy link
Member

veprbl commented May 19, 2019

@GrahamcOfBorg test buildbot

@lopsided98
Copy link
Contributor Author

That failure looks like a transient test timeout.

veprbl
veprbl approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86_64-linux tests fail on ofborg (just like in #57988) but pass locally.

@veprbl veprbl merged commit f6d2df3 into NixOS:master May 19, 2019
@lopsided98 lopsided98 deleted the buildbot-update branch May 19, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @veprbl