Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the API of Manœuvre to unify it with Burn #2171

Merged
merged 21 commits into from
May 18, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 18, 2019

  • Make the specification of intensity and timing happen at construction and ensure that a manœuvre is usable immediately after construction.
  • Make it easier to clone manœuvres by using shared_ptrs.
  • This PR is large because of API changes but it is supposed to be semantics-preserving.

}
} else {
CHECK(intensity.direction && intensity.duration);
// Циолко́вский's equation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Циолковский without the acute accent, this is not a dictionary entry.

@eggrobin eggrobin added the LGTM label May 18, 2019
@pleroy pleroy merged commit 69d5ee2 into mockingbirdnest:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants