Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openra: 20181215 -> 20190314… #61730

Closed
wants to merge 1 commit into from
Closed

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented May 20, 2019

…, openraPackages.engines.playtest: 20190106 -> 20190302, openraPackages.engines.bleed: 9c9cad1 -> 07dc2a1

Motivation for this change

version bump requested by najibpuchong on irc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

…06 -> 20190302, openraPackages.engines.bleed: 9c9cad1 -> 07dc2a1
@aanderse
Copy link
Member Author

@fusion809 @msteen @rardiol building openraPackages.engines.bleed fails when I build locally:

~/nixpkgs> nix-build -A openraPackages.engines.bleed
these derivations will be built:
  /nix/store/bmwmbb5rw0xy9l92r3qp2g8dmwr1205a-openra-bleed-07dc2a1.drv
building '/nix/store/bmwmbb5rw0xy9l92r3qp2g8dmwr1205a-openra-bleed-07dc2a1.drv'...
unpacking sources
unpacking source archive /nix/store/92ab04n0wz5kfcfjmx8zp63by3c7mb7v-source
source root is source
patching sources
configuring
building
build flags: SHELL=/nix/store/x0mlaj4z4ciycaycfwc36l1932mwywfj-bash-4.4-p23/bin/bash prefix=\$\(out\) DEBUG=false default man-page
make: *** No rule to make target 'default'.  Stop.
builder for '/nix/store/bmwmbb5rw0xy9l92r3qp2g8dmwr1205a-openra-bleed-07dc2a1.drv' failed with exit code 2
error: build of '/nix/store/bmwmbb5rw0xy9l92r3qp2g8dmwr1205a-openra-bleed-07dc2a1.drv' failed

Any thoughts?

@fusion809
Copy link
Contributor

fusion809 commented May 20, 2019

There were a few commits where in the man-page make target depended on the 'default' make target, which no longer existed—you're building one of them. This issue was fixed in OpenRA/OpenRA#16511. Now, man pages need to be built with the all make target and installed (i.e. moved to their appropriate locations) with the install-man-page target. But, sadly, that won't fix all the build problems recently introduced, as now OpenRA requires the MSBuild Mono package and Mono 5.10.x or later (preferably 5.12.x or later). Not sure if NixOS presently uses Mono 5.12.x or later, probably does.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 20, 2019

Related: #61394

@msteen
Copy link
Contributor

msteen commented May 20, 2019

As mentioned by @c0bw3b I already made a PR (#61394) to update the OpenRA engine releases and mods, so I vote to close this PR. Due to the things mentioned by @fusion809 the bleeding version has been updated to the latest commit before the changes were made to the build process.

@aanderse
Copy link
Member Author

@msteen don't I feel silly now... thanks for taking care of this!

@aanderse aanderse closed this May 20, 2019
@aanderse aanderse deleted the openra branch May 20, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants