Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightdm: 1.28.0 -> 1.30.0 #61644

Merged
merged 1 commit into from May 18, 2019
Merged

lightdm: 1.28.0 -> 1.30.0 #61644

merged 1 commit into from May 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2019

Motivation for this change

Waiting on rebuild all day :P,
so marking draft to make it clear
it hasn't had usual baseline of testing :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace self-assigned this May 17, 2019
@ofborg ofborg bot requested review from ocharles and worldofpeace May 17, 2019 21:15
@rembo10
Copy link
Contributor

rembo10 commented May 18, 2019

Tested this on NixOS and it seems to work fine. It also seems to have fixed the bug where XDG_RUNTIME_DIR wasn't being set which started happening on a recent nixos-unstable release.

worldofpeace
worldofpeace approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the changes, looks fine.

Ran it in a vm I don't see any new issues popping up in the output.

@worldofpeace worldofpeace marked this pull request as ready for review May 18, 2019 22:16
@worldofpeace worldofpeace merged commit cb3c214 into NixOS:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@ocharles ocharles Awaiting requested review from ocharles

Assignees

@worldofpeace worldofpeace

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @rembo10 @worldofpeace