Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minify: 2.0.0 -> 2.5.0, module #61713

Merged
merged 1 commit into from May 20, 2019
Merged

minify: 2.0.0 -> 2.5.0, module #61713

merged 1 commit into from May 20, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 19, 2019

Motivation for this change

Update, module, meta.

https://github.com/tdewolff/minify/releases/tag/v2.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit May 19, 2019 15:55
@kalbasit
Copy link
Member

Retrying Darwin.

error: cannot fork() for fetch-pack: Resource temporarily unavailable

@GrahamcOfBorg build minify

@mmahut
Copy link
Member

mmahut commented May 19, 2019

Tested on x86_64-linux, works for me.

@dtzWill dtzWill merged commit b8e578d into NixOS:master May 20, 2019
@dtzWill dtzWill deleted the update/minify-2.5.0 branch May 20, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @kalbasit @mmahut