Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caffeine-ng: init at 3.4.2 (and setproctitle: 1.1.9 -> 1.1.10) #61676

Merged
merged 3 commits into from May 26, 2019
Merged

caffeine-ng: init at 3.4.2 (and setproctitle: 1.1.9 -> 1.1.10) #61676

merged 3 commits into from May 26, 2019

Conversation

marzipankaiser
Copy link
Contributor

Motivation for this change

Caffeine-ng is a tray bar application to temporarily inhibit screensaver etc.

Things done
  • Added myself to maintainers
  • Updated setproctitle package (newer version was needed for caffeine-ng)
  • Packaged caffeine-ng
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

symphorien
symphorien approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me®, thanks for the PR!

@marzipankaiser marzipankaiser mentioned this pull request May 25, 2019
Closed
@Lassulus
Copy link
Member

tested without nix-review and seemed to work.

@Lassulus Lassulus merged commit c7bcd42 into NixOS:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marzipankaiser @Lassulus @symphorien