Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: df5323467efc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ce82d0b61a91
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jul 24, 2019

  1. nixos/couchdb: Prevent it from chowning /var/log to couchdb:couchdb

    The default for logFile is /var/log/couchdb.log, and the tmpfile rules chown
    ${dirOf cfg.logFile}, which is just /var/log, to couchdb:couchdb.
    
    This was found by Edes' report on IRC, which looked like
    
        Detected unsafe path transition /var/log → /var/log/journal during canonicalization of /var/log/journal
    
    While this bug has been present since the initial couchdb module in
    62438c0 by @garbas, this wasn't a
    problem, because the initial module only created and chowned /var/log
    if it didn't exist yet, which can't occur because this gets created in
    the initial phases of NixOS startup.
    
    However with the recent move from manual preStart chown scripts to
    systemd.tmpfiles.rules in 062efe0 (#59389),
    this chown is suddenly running unconditionally at every system
    activation, therefore triggering the above error.
    infinisil committed Jul 24, 2019
    Copy the full SHA
    5e97436 View commit details
    Browse the repository at this point in the history
  2. nixos/tests: Reenable couchdb

    Works just fine in current master
    infinisil committed Jul 24, 2019
    Copy the full SHA
    12eb0f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Couchdb: Don't chown /var/log to couchdb (#65347)

    Couchdb: Don't chown /var/log to couchdb
    infinisil committed Aug 9, 2019
    Copy the full SHA
    ce82d0b View commit details
    Browse the repository at this point in the history