New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intake: 0.4.4 -> 0.5.3 #66412
intake: 0.4.4 -> 0.5.3 #66412
Conversation
400b07d
to
cb21853
Compare
cb21853
to
440faae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still getting a fair number of failures
[39 built (6 failed), 253 copied (1574.9 MiB), 454.1 MiB DL]
error: build of '/nix/store/lxika718nsqqrv07gg6bfh2aj3j400jb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66412
1 package are marked as broken and were skipped:
python37Packages.imgaug
11 package failed to build:
python37Packages.aplpy python37Packages.blaze python37Packages.dask-glm python37Packages.dask-ml python37Packages.dask-xgboost python37Packages.datashader python37Packages.odo python37Packages.optuna python37Packages.starfish python37Packages.streamz python37Packages.sunpy
33 package were build:
python27Packages.bokeh python27Packages.colorcet python27Packages.holoviews python27Packages.hvplot python27Packages.panel python27Packages.param python27Packages.pyct python27Packages.pyviz-comms python27Packages.runway-python python37Packages.bokeh python37Packages.caffe python37Packages.colorcet python37Packages.dask python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-mpi python37Packages.distributed python37Packages.glymur python37Packages.holoviews python37Packages.hvplot python37Packages.image-match python37Packages.intake python37Packages.panel python37Packages.param python37Packages.pims python37Packages.pyct python37Packages.pyfftw python37Packages.pyviz-comms python37Packages.rl-coach python37Packages.runway-python python37Packages.scikitimage python37Packages.slicedimage python37Packages.stumpy
looks like a lot of the failures are with astropy being broken by the numpy update (numpy is more strict about memory layout/usage/casting etc). which causes a lot of tests to fail. :( |
To be fair, the following packages were also broken on master before #66348
Leaving only |
Either way, annoying that so much has broken from a minor bump on numpy. |
Oh you mean 55d82d5 broke it? That's out of scope for this PR as I'm only intending to fix what my other PR has broke. I kindof wish that ofborg would build all Python packages anytime one of them is changed in a PR. cc @grahamc |
@GrahamcOfBorg build python3Packages.param python3Packages.bokeh python3Packages.bokeh python3Packages.panel python3Packages.intake |
that would be huge increase in computational volume. For stuff that <50 rebuilds, a local nix-review suffices. For larger, then it makes sense to use something like staging to experiment with many potentially large breaking changes. |
hence the "I wish" 😄 Anyway, thanks for your help @jonringer. I'll fix the Darwin issue and merge. |
I can't replicate locally on my Darwin. I'll give it another shot. @GrahamcOfBorg build python3Packages.intake |
Motivation for this change
Fixing the intake package broken by #66348.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @costrouc @jonringer @pierothebear