Export transparency correctly in VRML #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
changed the title
whitequark
reviewed
Aug 9, 2019
src/export.cpp
Outdated
| struct STriangleSpan { | ||
| const STriangle *first, *past_last; | ||
|
|
||
| const STriangle *begin() const { return first; } |
There was a problem hiding this comment.
Nit: this should be properly called cbegin since it returns a const iterator, but it's probably better to ditch const here since it doesn't really do anything useful. (const in SolveSpace is only used for replacing by-value passing with by-const-reference.)
There was a problem hiding this comment.
I just copied the List<> API here tbh
Also, FWIW, begin() has both const and non-const overloads in the STL, and ranged-for uses only begin()
Anyway, ditched
There was a problem hiding this comment.
Oh, you're right, my bad.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opted for an explicit span container for clarity but that can be easily replaced with explicit iterator-
fors if you're not a fan