Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amazon image: fetch meta-data everytime in case if something changes #66487

Closed
wants to merge 1 commit into from
Closed

amazon image: fetch meta-data everytime in case if something changes #66487

wants to merge 1 commit into from

Conversation

philandstuff
Copy link
Contributor

Motivation for this change

Context: this PR assumes you are running an instance in Amazon EC2.

Currently, after a reboot, a NixOS instance will re-configure itself, but to the user-data value which was set at instance creation.

AWS support changing user data while an instance is stopped. Further, if you use CloudFormation to manage your EC2 instances, and you make a change to user data, your instance will be stopped, user data updated, and instance restarted.

This PR cherry-picks a commit from unmerged PR #19031 which re-downloads user data on every boot, not just the first boot, so that changes to user-data can be picked up and applied. This will mean that instances can be truly declaratively managed using AWS CloudFormation - a change to user-data in your CloudFormation template will cause the instance to be reconfigured to the desired state.

This PR conflicts with issue #41826, which says we shouldn't reconfigure machines after reboot at all. That said, I think the current behaviour is confusing, and either this PR or #41826 would be better.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@hyperfekt hyperfekt mentioned this pull request Aug 14, 2019
Draft
6 tasks
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000
Copy link
Member

@philandstuff please resolve the merge conflict.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@SuperSandro2000 SuperSandro2000 added 2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jan 18, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philandstuff @worldofpeace @SuperSandro2000 @matejc