New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liquidprompt: init at 2018-05-21 #66429
Conversation
Is it possible to ask upstream for a tag? |
Done! |
@GrahamcOfBorg build liquidprompt |
ec322c7
to
0a4505b
Compare
@GrahamcOfBorg build liquidprompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the script installed at $out/share/{bash,zsh}/plugins/liquidprompt/
? As far as I know, those are not standard locations, and it may make it difficult to start the script. I would rather install at $out/bin
.
It would also be interesting to install the default configuration and theme files. They would serve as examples for the user willing to change configuration and theming. |
As liquidprompt needs to be sourced instead of executed (see missing executable bit) this file definitly does not belong into What files would you add to the package and where? Personally, I don't really see the advantages of putting default configs into the package as the majority will define their own config. And if you need a reference, you will be better of with reading the README of liquidprompt. |
According to https://superuser.com/questions/176783/what-is-the-difference-between-executing-a-bash-script-vs-sourcing-it both execution and sourcing of a bash shell script uses It is desirable that the script be placed in a directory in Currently I am sourcing it with something like
which is not very user friendly and will change in the next rebuild if the source or any dependency changes. If it can be found in
It does not need to be executable, though. That would be enough to prevent it from being executed instead of sourced. Other distributions like Arch (AUR) installs it at |
I would install |
0a4505b
to
0c00a15
Compare
Motivation for this change
Add liquidprompt package at 2018-05-21. Unfortunately the last tag in the repo is a while back and missing features, so I took the rev of the most recent commit.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)