Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm: 0.9.8.5 -> 0.9.9.5 #66430

Closed
wants to merge 1 commit into from
Closed

glm: 0.9.8.5 -> 0.9.9.5 #66430

wants to merge 1 commit into from

Conversation

szszszsz
Copy link

Update glm package to latest version

Builds; not tested in action

Motivation for this change

Package version update to the latest. API has changed lately, and 0.9.8 does not work with new applications.
Removed GCC7 platform patch, ported from newer glm - commit 384dab02e45a8 (from which the patch is ported) is already a part of 0.9.9.5 release, and available from 0.9.9.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Fedora 29)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Calling last file updater - cc @globin

@szszszsz
glm: 0.9.8.5 -> 0.9.9.5
962dfaa 
Remove GCC7 platfrom patch, ported from newer glm
384dab02e45a8ad3c1a3fa0906e0d5682c5b27b9 is already a part of 0.9.9.5 release, and available from 0.9.9.0

Builds; not tested in action
@szszszsz
Copy link
Author

cc @Fuuzetsu

@ofborg ofborg bot requested a review from Fuuzetsu August 10, 2019 10:59
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build glm

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@szszszsz the build fails on darwin, do you mind having a look?

@szszszsz
Copy link
Author

szszszsz commented Sep 2, 2019

Not at all, but I do not have spare time at the moment. I hope to do so in 2-4 weeks.
Looking briefly though the Darwin build messages are not really informative to me.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@szszszsz
Copy link
Author

szszszsz commented Jun 3, 2020 •
edited

Hi!
Sorry, but it turns out that practically I cannot find time to pursue this further. I see there is a merge conflict as well - possibly it was already updated. Please confirm and close this PR if so.

Edit: Ah, I guess I should not have replied to not trigger the stale-bot.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@Lassulus
Copy link
Member

update could still be made, the only conflict is a name/pname change which happened upstream. You can also close this if you want and maybe someone else will do it.

@szszszsz
Copy link
Author

@Lassulus Thank you for the info!
Let me close this PR for now, and reopen when I will find more room to work on it.

@szszszsz szszszsz closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szszszsz @mmahut @Lassulus @alyssais @Janik-Haag