Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.gtimelog: 0.9.1 -> unstable-2020-05-16 #66332

Merged
merged 1 commit into from Aug 15, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Aug 8, 2019

Motivation for this change

The content of this PR is the update of the gtimelog package.

Here it was updated from the outdated 0.9.1 version to the current HEAD, because the last release is a bit old and in the meantime SMTP support has been added. As soon as the next stable version is released, I would again set a release as a version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ocharles

@oxzi
Copy link
Member Author

oxzi commented Sep 9, 2019

I have updated the PR to the most recent commit of the gtimelog repository. Furthermore, I rebased my PR branch to not conflict with the current master after 72e7d56.

@oxzi oxzi changed the title pythonPackages.gtimelog: 0.9.1 -> unstable-2019-08-06 pythonPackages.gtimelog: 0.9.1 -> unstable-2019-08-28 Sep 9, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@oxzi oxzi requested a review from jonringer as a code owner July 27, 2020 21:36
@oxzi
Copy link
Member Author

oxzi commented Jul 27, 2020

After nearly a year I have rebased my PR and updated it to the newest unstable version, because there is still no real release.

@oxzi oxzi changed the title pythonPackages.gtimelog: 0.9.1 -> unstable-2019-08-28 pythonPackages.gtimelog: 0.9.1 -> unstable-2020-05-16 Jul 27, 2020
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 66332 1

3 packages built:
- gtimelog (python27Packages.gtimelog)
- python37Packages.gtimelog
- python38Packages.gtimelog

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the package has no tests you should add pythonImportChecks.

pkgs/development/python-modules/gtimelog/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gtimelog/default.nix Outdated Show resolved Hide resolved
Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>
@mweinelt
Copy link
Member

Apparently I missed the checkPhase, my bad.

@oxzi
Copy link
Member Author

oxzi commented Aug 15, 2020

No problem, now it checks it twice.

@mweinelt mweinelt merged commit 5ccf68e into NixOS:master Aug 15, 2020
@oxzi oxzi deleted the gtimelog-0.11.3 branch August 15, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants