Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.0.8 -> 6.0.10 #66405

Merged
merged 2 commits into from Sep 7, 2019
Merged

virtualbox: 6.0.8 -> 6.0.10 #66405

merged 2 commits into from Sep 7, 2019

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update VirtualBox

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @svanderburg

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg test virtualbox

@ofborg ofborg bot requested review from svanderburg and flokli August 9, 2019 22:43
@flokli
Copy link
Contributor

flokli commented Aug 10, 2019

@NeQuissimus we should now be able to re-enable UART in the virtualbox tests, as the upstream bug should be fixed according to the release notes:

Serial: fixed guru meditation when raw mode is enabled (bug 18632)

see #60943 for context.

cc @ambrop72

@flokli
Copy link
Contributor

flokli commented Aug 10, 2019

Hm, the tests still seem to fail when enabling uart:

p2qjm5ncv6n0zw0gv7fk2fjiglj0qmvz-vm-test-run-virtualbox-systemd-detect-virt.drv.log
b2vx4dhb8rvgmqy0yns1gl6v9blpl9zh-vm-test-run-virtualbox-simple-gui.drv.log
9j9sfd3cak25zzzhsxx61l08r045k1dx-vm-test-run-virtualbox-net-hostonlyif.drv.log
872ix9w0vg7izkm0ni6gsg15jdb8imjm-vm-test-run-virtualbox-simple-cli.drv.log

@ambrop72, any idea?

@ambrop72
Copy link
Contributor

@flokli VirtualBox is just broken in master currently, see #65564. I guess it will work on 19.03.

@ambrop72
Copy link
Contributor

@flokli At least on the first log I see the signal 6 error. Anyway did you try without enabling the uart?

@flokli
Copy link
Contributor

flokli commented Aug 14, 2019

yeah, it's both broken with and without UART. I fear we need to fix #65564 first.

@ambrop72
Copy link
Contributor

We could try it out on 19.03 though.

@flokli
Copy link
Contributor

flokli commented Aug 17, 2019

Yeah, or cherry-pick it on top of f79fd2e826dd95b3b64839d3e0bec8ae1dfab17e~1…

But I guess for merging it to 19.03, we need to fix unstable first.

@ambrop72 ambrop72 mentioned this pull request Sep 3, 2019
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Sep 4, 2019

@NeQuissimus Can this be rebased on top of latest master?

@ofborg ofborg bot requested a review from cdepillabout September 4, 2019 15:27
@ambrop72
Copy link
Contributor

ambrop72 commented Sep 4, 2019

Could you add this cleanup of tests to this PR?
https://github.com/ambrop72/nixpkgs/commits/virtualbox-cleanup

@ambrop72 @NeQuissimus
tests/virtualbox: Clean up unnecessary things.
a97a047 
Always enable the UART because the VirtualBug bug that required running without the UART was fixed in 6.0.10. Stop using an old kernel version because the tests work with the default kernel.

(cherry picked from commit ae93571)
@ofborg ofborg bot added the 6.topic: nixos label Sep 5, 2019
@flokli
Copy link
Contributor

flokli commented Sep 5, 2019

@GrahamcOfBorg test virtualbox

@flokli
Copy link
Contributor

flokli commented Sep 7, 2019

Switched my system to this commit, and also ran the tests successfully.

Thanks!

@flokli flokli merged commit db1f05c into NixOS:master Sep 7, 2019
@NeQuissimus NeQuissimus deleted the virtualbox_6_0_10 branch February 14, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@flokli flokli Awaiting requested review from flokli

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @flokli @ambrop72