Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazelisk: 0.0.8 -> 1.0 #66353

Merged
merged 1 commit into from Aug 9, 2019
Merged

bazelisk: 0.0.8 -> 1.0 #66353

merged 1 commit into from Aug 9, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 8, 2019

Motivation for this change

Changelog: https://github.com/bazelbuild/bazelisk/releases/tag/v1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit August 8, 2019 23:38
@kalbasit
Copy link
Member

kalbasit commented Aug 9, 2019

@GrahamcOfBorg build bazelisk

is ofborg still failing on Darwin 🤔

jonringer
jonringer reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS

However, binary seems to immediately die

[nix-shell:~/.cache/nix-review/pr-66353]$ ./results/bazelisk/bin/bazelisk --help
2019/08/08 18:38:19 could not run Bazel: could not start Bazel: fork/exec /home/jon/.cache/bazelisk/bin/bazelbuild/bazel-0.28.1-linux-x86_64: no such file or directory

@kalbasit
Copy link
Member

kalbasit commented Aug 9, 2019

@jonringer yea this package does not work on NixOS. It's mainly intended for other OSes.

@kalbasit kalbasit merged commit 1567269 into NixOS:master Aug 9, 2019
@marsam marsam deleted the update-bazelisk branch August 9, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @kalbasit @jonringer