Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/beegfs: mark as broken #66352

Merged
merged 1 commit into from Aug 10, 2019
Merged

nixos/beegfs: mark as broken #66352

merged 1 commit into from Aug 10, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Aug 8, 2019 •
edited

Motivation for this change

BeeGFS is a fantastic high performance file system. However, after running it for a few months last year the meta data daemon kept crashing randomly in production use (support from the manufacturer requires a paid support contract). The current version that is nixpkgs is outdated and I don not want to maintain it any longer. The build system is purely based on make file and is hard to maintain.

Things done

Mark beegfs as broken.

Removed the following items:

  • the main package
  • the kernel module
  • nixos module
  • tests
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@infinisil
Copy link
Member

If this gets completely removed, I'd like to have a mkRemovedOptionModule (or two actually, one for the enable option and one for the others), and a throw for the package.

@markuskowa
Copy link
Member Author

@volth good point. My first though was to clean it up but maybe it is better to just mark it broken and remove it in a later release.

@markuskowa markuskowa changed the title nixos/beegfs: remove module, packages, and tests nixos/beegfs: mark as broken Aug 9, 2019
@infinisil infinisil merged commit cf2a158 into NixOS:master Aug 10, 2019
@markuskowa markuskowa deleted the rm-beegfs branch August 18, 2019 09:35
@markuskowa markuskowa mentioned this pull request Nov 24, 2019
Closed
flokli added a commit to flokli/nixpkgs that referenced this pull request Nov 24, 2019
@flokli
beegfs: remove
8ab403c 
This has been marked as broken since NixOS#66352

Closes NixOS#73998.
@flokli flokli mentioned this pull request Nov 24, 2019
Merged
10 tasks
aszlig added a commit to openlab-aux/vuizvui that referenced this pull request Dec 8, 2019
@aszlig
core/tests: Remove beegfs test
080c314 
The test has been removed upstream[1] for the following reason[2]:

> BeeGFS is a fantastic high performance file system. However, after
> running it for a few months last year the meta data daemon kept
> crashing randomly in production use (support from the manufacturer
> requires a paid support contract). The current version that is nixpkgs
> is outdated and I do not want to maintain it any longer. The build
> system is purely based on make file and is hard to maintain.

[1]: NixOS/nixpkgs@c3e17ef
[2]: NixOS/nixpkgs#66352

Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @infinisil