Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse: 0.3.4 -> 0.4.1 #66372

Merged
merged 3 commits into from Aug 12, 2019
Merged

reuse: 0.3.4 -> 0.4.1 #66372

merged 3 commits into from Aug 12, 2019

Conversation

kirelagin
Copy link
Member

@kirelagin kirelagin commented Aug 9, 2019 •
edited

  • Add new Python packages (dependencies):
    • boolean.py
    • license-expression
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FlorianFranzen

@kirelagin kirelagin requested a review from FRidh as a code owner August 9, 2019 09:30
@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

@GrahamcOfBorg build reuse pythonPackages.boolean-py pythonPackages.license-expression

@mmahut mmahut merged commit 11bbc69 into NixOS:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kirelagin @mmahut