Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.1.4 -> 1.2.1 #66375

Merged
merged 2 commits into from Aug 11, 2019
Merged

syncthing: 1.1.4 -> 1.2.1 #66375

merged 2 commits into from Aug 11, 2019

Conversation

emmanuelrosa
Copy link
Contributor

syncthing-gtk: add missing runtime dependencies

NixOS: fix syncthing-init NixOS test

Motivation for this change

The purpose of this change is to upgrade syncthing from 1.1.4 to 1.2.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • syncthing-init
    • syncthing-relay
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    • syncthing-tray
    • qsyncthingtray
    • syncthing-gtk
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: nixos label Aug 9, 2019
@Lassulus
Copy link
Member

Lassulus commented Aug 9, 2019

@GrahamcOfBorg build syncthing

Emmanuel Rosa and others added 2 commits August 11, 2019 08:35
@emmanuelrosa
syncthing: 1.1.4 -> 1.2.1
d80670b 
syncthing-gtk: add missing runtime dependencies

NixOS: fix syncthing-init NixOS test
@emmanuelrosa
syncthing: clean up package
fd39791 
Thank you, @Lassulus
@Lassulus
Copy link
Member

@GrahamcOfBorg test syncthing-init syncthing-relay

bachp
bachp approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sucessfully running on my server

@Lassulus Lassulus merged commit 612871e into NixOS:master Aug 11, 2019
@infinisil infinisil mentioned this pull request Aug 11, 2019
Merged
@infinisil
Copy link
Member

The ofborg checks didn't succeed, which breaks master evaluation (in addition to another cause), both are fixed with above PR. Reviewers should look at these checks before merging

@emmanuelrosa emmanuelrosa deleted the syncthing-1.2.1 branch August 12, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emmanuelrosa @Lassulus @infinisil @bachp