New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cppclean: 2018-05-12 -> 0.13 #66373
cppclean: 2018-05-12 -> 0.13 #66373
Conversation
name = "cppclean-unstable-${version}"; | ||
version = "2018-05-12"; | ||
name = "cppclean-${version}"; | ||
version = "v0.13"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the v prefix to rev
and also consider using pname
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (thanks, @jonringer::) )
Thank you! Can you please squash your commits into just one? @GrahamcOfBorg build cppclean |
@mmahut I do not have write access to master afaik, so squash merging will need to be done by someone who has the correct permissions, right? |
@nthorne you don't need access to NixOS:master, this PR is merging a branch you control into a branch from NixOS. So just edit the branch you made the PR from to see the changes reflected here. The changes you want to squash the commits:
if you need to do more significant git history changes, something like |
Updated according to instructions from @jonringer (thanks!) |
@GrahamcOfBorg build cppclean |
Built and tested. Thanks. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @