Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx-qt5: fix build #66371

Merged
merged 1 commit into from Aug 9, 2019
Merged

fcitx-qt5: fix build #66371

merged 1 commit into from Aug 9, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented Aug 9, 2019

Motivation for this change

Fixes #65547. Should probably be backported to fix #65716 as well.

Instead of replacing the paths in the files generated by cmake (which turned out to be fragile), we now just patch the source cmake files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ericsagnes @worldofpeace @nezumi1503

@gebner gebner merged commit 6446e7e into NixOS:master Aug 9, 2019
@worldofpeace
Copy link
Contributor

Thanks @gebner looks correct 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fcitx-qt5 fails to build on stable fcitx-qt5 fails to build on unstable
2 participants
@gebner @worldofpeace