Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.36.1 -> 1.37.0 #66374

Merged
merged 1 commit into from Aug 9, 2019
Merged

vscode: 1.36.1 -> 1.37.0 #66374

merged 1 commit into from Aug 9, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Aug 9, 2019 •
edited

Motivation for this change

https://code.visualstudio.com/updates/v1_37

  • There is no linux/macOS release for vscodium yet. Shall we wait for it?
  • I don't know if I can specify a platform to update-source-version so I downloaded the
    dmg for macOS manually and calculated the hash with sha256sum, hence its longer size. I can do it my mac later.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eadwu @Synthetica

@eadwu
Copy link
Member

eadwu commented Aug 9, 2019 •
edited

VSCodium seems to have an issue [1]. Oddly, there is a release for 1.999.0 which is from a month ago. Anyway confirmed the x86_64 hash. The hash I got for darwin was 1is04anvhl2b354h5w7i5qi7ixhzna277f7xdy4qj9gjby6zydc6 using nix-universal-prefetch fetchurl --url "https://vscode-update.azurewebsites.net/1.37.0/darwin/stable".

[1] VSCodium/vscodium#235

@angristan
Copy link
Member Author

Thanks for referencing the issue @eadwu! We'll wait until the release artifacts are available.

I didn't know nix-universal-prefetch! I got the same hash, I will update the PR.

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 9, 2019 •
edited

I don't think we need to upgrade both at the same time, they're independent distributions.
(plus it could take a while)

worldofpeace
worldofpeace approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes, verified darwin hash is
1is04anvhl2b354h5w7i5qi7ixhzna277f7xdy4qj9gjby6zydc6.

@worldofpeace worldofpeace merged commit f3b18b9 into NixOS:master Aug 9, 2019
@angristan
Copy link
Member Author

OK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angristan @eadwu @worldofpeace