Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database.ti.msp430: Initial import of device list from slau320ag #148

Merged
merged 1 commit into from Aug 10, 2019

Conversation

smunaut
Copy link
Contributor

@smunaut smunaut commented Aug 10, 2019

Signed-off-by: Sylvain Munaut tnt@246tNt.com

MSP430Device('MSP430FR6045', 0x99, 0xeb82, None, core='430Xv2', type='fram', features=['quick.sram.r', 'quick.sram.w', 'quick.fram.r', 'quick.fram.w']),
MSP430Device('MSP430FR60471', 0x99, 0xee82, None, core='430Xv2', type='fram', features=['quick.sram.r', 'quick.sram.w', 'quick.fram.r', 'quick.fram.w']),
MSP430Device('MSP430FR6047', 0x99, 0xea82, None, core='430Xv2', type='fram', features=['quick.sram.r', 'quick.sram.w', 'quick.fram.r', 'quick.fram.w']),
MSP430Device('MSP430FR6820 (DGG package)', 0x99, 0x5582, None, core='430Xv2', type='fram', features=['quick.sram.r', 'quick.sram.w', 'quick.fram.r', 'quick.fram.w']),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of packages looks like it wants to be its own field.

Copy link
Contributor Author

@smunaut smunaut Aug 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add a field split for the devices where ID depends on the package based on the text comment, but I'm not going to lookup all package for all chips where it doesn't matter ... that info is not in the slau320ag and it would take way too long to look them up.

Something like pkg_variants = ['PM', 'RGC'] or [ '100 pins', '80 pins']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, of course, I'm not suggesting looking up all packages. only splitting the info where it matters.

"pkg_variants", # If ID depends on package, list variant(s)
))):

__slot__ = ()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK Python doesn't have anything called __slot__, should this be __slots__? (Not that it matters much in this case)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf yeah, typo ... just trying to preserve the namedtuple thing.

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
@whitequark whitequark merged commit 82185c8 into GlasgowEmbedded:wip-applet.debug.msp430 Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants