Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slrn: 1.0.2 -> 1.0.3a #66355

Merged
merged 1 commit into from Aug 9, 2019
Merged

slrn: 1.0.2 -> 1.0.3a #66355

merged 1 commit into from Aug 9, 2019

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Aug 9, 2019

Motivation for this change

Update to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry

jonringer
jonringer approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (although version is unstable)
binaries seem to work
leaf package

[3 built, 1 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66355
1 package were build:
slrn

@bdesham
Copy link
Contributor Author

bdesham commented Aug 9, 2019

@jonringer Thanks for taking a look!

What do you mean by “unstable”? Is it the fact that the app itself advertises the version as 1.0.3 even though the “real” version is 1.0.3a?

@jonringer
Copy link
Contributor

yea, to me that means alpha. Under semver, a patch would bump it to 1.0.4

@bdesham
Copy link
Contributor Author

bdesham commented Aug 9, 2019

Yeah, I’m not sure what the versioning policy is but it’s definitely not semver 🙂

@markuskowa
Copy link
Member

@GrahamcOfBorg build slrn

@markuskowa markuskowa merged commit 7c1393c into NixOS:master Aug 9, 2019
@bdesham bdesham deleted the slrn-1.0.3a branch August 9, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdesham @jonringer @markuskowa