Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.xapian: init at 1.4.12 #66356

Merged
merged 1 commit into from Aug 24, 2019
Merged

pythonPackage.xapian: init at 1.4.12 #66356

merged 1 commit into from Aug 24, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 9, 2019 •
edited

Motivation for this change

trying to close old tickets. closes #49662

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ nix path-info -Sh ./result
/nix/store/yp01ykz45mhdidya3hw8n0l75vgp9ssv-python3.7-xapian-1.4.12      111.7M

everything is linked alright

$ ldd ./result/lib/python3.7/site-packages/xapian/_xapian.cpython-37m-x86_64-linux-gnu.so
        linux-vdso.so.1 (0x00007ffd74d1f000)
        libxapian.so.30 => /nix/store/pwk48a4z62zapl66hhammjb7r55bwzma-xapian-1.4.12/lib/libxapian.so.30 (0x00007f2871d0f000)
        libstdc++.so.6 => /nix/store/pjx3f50x0qziyivs7rbg5s12p99nn2np-gcc-7.4.0-lib/lib/../lib64/libstdc++.so.6 (0x00007f2871b85000)
        libm.so.6 => /nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27/lib/libm.so.6 (0x00007f28719ef000)
        libc.so.6 => /nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27/lib/libc.so.6 (0x00007f2871839000)
        /nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007f2872060000)
        libgcc_s.so.1 => /nix/store/pjx3f50x0qziyivs7rbg5s12p99nn2np-gcc-7.4.0-lib/lib/../lib64/libgcc_s.so.1 (0x00007f2871820000)
        librt.so.1 => /nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27/lib/librt.so.1 (0x00007f2871814000)
        libz.so.1 => /nix/store/w3wqang215is14xqajycbxmd52b44qkw-zlib-1.2.11/lib/libz.so.1 (0x00007f28717f5000)
        libuuid.so.1 => /nix/store/37rzlcp0v8c9ifmbjix17g5rfk4lrvnp-util-linux-2.33.2/lib/libuuid.so.1 (0x00007f28717ec000)
        libpthread.so.0 => /nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27/lib/libpthread.so.0 (0x00007f28717cb000)

not sure if i should remove the docs that get built though, it's about half of the package size

$ du -hd0 ./result/*
2.5M    ./result/lib
8.0K    ./result/nix-support
2.2M    ./result/share

structure

$ tree -L 5 ./result
./result
├── lib
│   └── python3.7
│       └── site-packages
│           └── xapian
│               ├── __init__.cpython-37.opt-1.pyc
│               ├── __init__.cpython-37.pyc
│               ├── __init__.py
│               └── _xapian.cpython-37m-x86_64-linux-gnu.so
├── nix-support
│   └── propagated-build-inputs
└── share
    └── doc
        └── xapian-bindings
            └── python3
                ├── examples
                └── html

nix-review pr 66356
...
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66356
2 package were build:
python27Packages.xapian python37Packages.xapian

@jonringer jonringer requested a review from FRidh as a code owner August 9, 2019 01:31
@risicle
Copy link
Contributor

risicle commented Aug 11, 2019

WFM macos 10.13

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build python27Packages.xapian python37Packages.xapian

@mmahut mmahut merged commit b585bba into NixOS:master Aug 24, 2019
@jonringer jonringer deleted the add-python-xapian branch August 25, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @risicle @mmahut